Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1462 Move the git commit parsing out of the start.sh and into the build #1463

Merged
merged 7 commits into from Jan 26, 2023
Merged

Fixes #1462 Move the git commit parsing out of the start.sh and into the build #1463

merged 7 commits into from Jan 26, 2023

Conversation

jonespm
Copy link
Member

@jonespm jonespm commented Dec 8, 2022 •
edited

It was suggested to

  • Have this commands to parse git in a separate file
  • Add changes to Dockerfile.openshift.
  • Rebase to latest code

@jonespm jonespm changed the title Move the git commit parsing out of the start.sh and into the build #1462 Fixes #1462 Move the git commit parsing out of the start.sh and into the build Dec 8, 2022
@jonespm jonespm linked an issue Dec 8, 2022 that may be closed by this pull request
Move the git commit parsing out of the start.sh and into the build #1462
Closed
@jonespm
Move the git commit parsing out of the start.sh and into the build tl…
7f2b187 
…-its-umich-edu#1462

THIS IS A draft: It was suggested to have this command to parse git in a
separate file and also need to add to Dockerfile.openshift.

Also this is going to need to be rebased.
@jonespm
Removing the .git directory removal from here for now.
e1c9271
@jonespm
* Have this commands to parse git in a separate file
f04b5ab 
* Add changes to Dockerfile.openshift.
@jonespm jonespm marked this pull request as ready for review January 23, 2023 22:01
@jonespm
Copy link
Member Author

jonespm commented Jan 23, 2023

docker scan my-learning-analytics-web doesn't report any critical/high issues after this, only low and medium.

ssciolla
ssciolla approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@ssciolla ssciolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and git command wasn't found in the container. Couple comments to consider.

scripts/git_version_info.sh Outdated Show resolved Hide resolved
scripts/git_version_info.sh Outdated Show resolved Hide resolved
scripts/git_version_info.sh Outdated Show resolved Hide resolved
zqian
zqian approved these changes Jan 25, 2023
View reviewed changes
start.sh Outdated Show resolved Hide resolved
jonespm and others added 3 commits January 26, 2023 09:08
@jonespm @ssciolla
Update scripts/git_version_info.sh
990fa9f 
Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com>
@jonespm
Fix for shellcheck issue
a3902e3
@jonespm
Adding all git info to start script
38c5b42
@jonespm jonespm merged commit 6b3be94 into tl-its-umich-edu:master Jan 26, 2023
@jonespm jonespm deleted the issue_1462 branch January 26, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zqian zqian zqian approved these changes

@ssciolla ssciolla ssciolla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move the git commit parsing out of the start.sh and into the build
3 participants
@jonespm @zqian @ssciolla