New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store dates from cron "as-is", remove time conversion from cron #1490
Comments
Use the LTI launch timezone value to detect it. Another option would be to use the browser timezone, but LTI is the best approach since it will match the timezone in Canvas. |
@jaydonkrooss Assigning you as an observer on this one. |
Here is the time zone related change with newest Django 4 upgrade. |
I recommended this issue to Jaydon. He can discuss it with me as he makes progress with it. |
From what I've been gathering on the previous issue #1484, it seems that we're not trying to have any more local time conversions when populating the MyLA database, instead putting the conversion client-side. Based on this commit for that initial timezone fix, I'm thinking the only fields we care about in this case are Specific changes I'm considering:
|
Also cleaned up some bad grammar and grouped some related lines together.
Some comments were vague. More explicit comments make configuring the app easier to understand.
Cron runs fine and no issues detected in beta testing. |
Thank you for contributing to this project!
Describe your problem or feature you'd like added
It was noted on some recent fixes like #1484 that MyLA is storing values in local time. We had some discussion that this probably isn't needed and the application could do the conversion in the API (either in GraphQL or in the view) to the value in the settings. This might require some minor migration or we can just require dropping the tables and re-running the cron.
This would probably be made easier if the old assignment view API's were removed #1492 and the cron for the UDW #1493 was also removed.
The text was updated successfully, but these errors were encountered: