Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTime fields should be displayed in the users local time #1491

Closed
jonespm opened this issue Mar 6, 2023 · 6 comments · Fixed by #1556
Closed

DateTime fields should be displayed in the users local time #1491

jonespm opened this issue Mar 6, 2023 · 6 comments · Fixed by #1556
Assignees

Comments

@jonespm
Copy link
Member

jonespm commented Mar 6, 2023

Thank you for contributing to this project!

Describe your problem or feature you'd like added

It was noted that times displayed are local to a specific time on the server (America/Detroit by default) and it would probably be useful to have the times match what's in Canvas for the user to their local time. This is mostly for the assignment view.

Describe the solution you'd like

Either get and use the custom LTI launch variable Person.address.timezone or use the browsers time zone to do the time conversions for the user. This would require storing the times in UTC first locally via #1490

@jennlove-um jennlove-um added this to To do in MyLA-2024.01.01 via automation Sep 27, 2023
@jennlove-um
Copy link
Contributor

Research the impact of this

@jennlove-um
Copy link
Contributor

@jaydonkrooss Assigning you as an observer on this one.

@jennlove-um
Copy link
Contributor

There is a library change in the Django upgrade that may affect this.

@pushyamig
Copy link
Contributor

Here is the time zone related change with newest Django 4 upgrade.
https://docs.djangoproject.com/en/4.2/releases/4.0/#zoneinfo-default-timezone-implementation

@lsloan lsloan moved this from To do to In progress in MyLA-2024.01.01 Dec 7, 2023
@lsloan
Copy link
Member

lsloan commented Dec 7, 2023

Canvas provides the user's time zone in the variable $Person.address.timezone when LTIs are launched. A custom launch parameter can be set with this value.

lsloan added a commit that referenced this issue Dec 21, 2023
lsloan added a commit that referenced this issue Dec 21, 2023
Removed imports that weren't being used and some that were duplicated.  Organized the remaining imports.  Added `pytz`.
lsloan added a commit that referenced this issue Dec 21, 2023
lsloan added a commit that referenced this issue Dec 21, 2023
Handle the user's time zone from Canvas more carefully.  Don't assume it is set, doesn't have extraneous whitespace, or is valid.  If it's not set or invalid, use the `TIME_ZONE` set in `env.hjson`.
lsloan added a commit that referenced this issue Jan 5, 2024
Will remove from model shortly…
lsloan added a commit that referenced this issue Jan 8, 2024
lsloan added a commit that referenced this issue Jan 9, 2024
MyLA-2024.01.01 automation moved this from In progress to Review/QA Jan 16, 2024
lsloan added a commit that referenced this issue Jan 16, 2024
…conversion

remove local-time fields, add time zone (iss. #1490, #1491)
@jennlove-um
Copy link
Contributor

Cron runs fine and no issues detected in beta testing.

@jennlove-um jennlove-um moved this from Review/QA to Done in MyLA-2024.01.01 Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants