Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies where possible (#52) #55

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Update dependencies where possible (#52) #55

merged 1 commit into from
Mar 30, 2021

Conversation

ssciolla
Copy link
Contributor

@ssciolla ssciolla commented Mar 29, 2021 •
edited
Loading

This PR updates the coverage, Django, and mysqlclient dependencies to the latest available versions. python-dotenv was held back due to incompatibility with api-utils-python (which only allows 0.14.X). The test suite passed, and the application ran properly in the test environment. The PR aims to resolve #52.

@ssciolla ssciolla added enhancement New feature or request dependencies Involves changes to/discussion of dependencies (language version, packages, libraries, etc.) labels Mar 29, 2021
@ssciolla ssciolla mentioned this pull request Mar 29, 2021
Closed
zqian
zqian approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@zqian zqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the PR successfully on localhost and with Canvas test environment. The test suite passed, too.

@ssciolla
Copy link
Contributor Author

Thanks, @zqian!

@ssciolla ssciolla merged commit df38550 into tl-its-umich-edu:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zqian zqian zqian approved these changes

@pushyamig pushyamig Awaiting requested review from pushyamig

Assignees
No one assigned
Labels
dependencies Involves changes to/discussion of dependencies (language version, packages, libraries, etc.) enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perform dependency update
2 participants
@ssciolla @zqian