Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Dask-proxy #22

Merged
merged 3 commits into from
Nov 10, 2021
Merged

add Dask-proxy #22

merged 3 commits into from
Nov 10, 2021

Conversation

tlambert03
Copy link
Owner

lets the dask array returned from to_dask be opened even after the file has been closed (... it will reopen on compute())

@tlambert03
Copy link
Owner Author

addresses part of #19
pulled from the proxy I made for aicsimageio

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #22 (80dd178) into main (5e51447) will increase coverage by 0.56%.
The diff coverage is 97.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   86.77%   87.34%   +0.56%     
==========================================
  Files          10       11       +1     
  Lines        1066     1106      +40     
==========================================
+ Hits          925      966      +41     
+ Misses        141      140       -1     
Impacted Files Coverage Δ
src/nd2/_sdk/latest.pyx 84.54% <50.00%> (-0.34%) ⬇️
src/nd2/_dask_proxy.py 100.00% <100.00%> (ø)
src/nd2/nd2file.py 92.79% <100.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e51447...80dd178. Read the comment docs.

@tlambert03 tlambert03 merged commit 9eddd9c into main Nov 10, 2021
@tlambert03 tlambert03 deleted the dask-proxy branch November 10, 2021 23:34
@VolkerH
Copy link
Contributor

VolkerH commented Nov 11, 2021

nice ! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants