Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommendations for light terminal themes #94

Closed
wants to merge 1 commit into from

Conversation

k4j8
Copy link

@k4j8 k4j8 commented Apr 27, 2020

Update the README to suggest a color configuration for light terminals themes. With the current default settings, the white text is not legible on most light terminal themes.

Update the README to suggest a color configuration for light terminals
themes. With the current default settings, the white text is not legible on
most light terminal themes.
@@ -37,7 +38,17 @@ You can configure the behaviour and output of the `tldr` client by setting envir
export TLDR_CACHE_ENABLED=1
export TLDR_CACHE_MAX_AGE=720

For light terminal themes, the following colors are recommended:

export TLDR_COLOR_BLANK="yellow"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not black though?

@k4j8
Copy link
Author

k4j8 commented Apr 28, 2020

Good point. Although black wasn't an option, "grey dark" was. I tried the following code on all default light themes in Gnome Terminal and like it more. What do you think? If acceptable, I will modify and resubmit.

export TLDR_COLOR_BLANK="grey dark"
export TLDR_COLOR_NAME="grey dark"
export TLDR_COLOR_DESCRIPTION="grey dark"
export TLDR_COLOR_EXAMPLE="blue"     
export TLDR_COLOR_COMMAND="red"
export TLDR_COLOR_PARAMETER="grey dark"

Black on light yellow

black on light yellow

Black on white

black on white

Tango light

tango light

Solarized light

solarized light

Current defaults (bad) - black on white

default settings - black on white

@zlatanvasovic
Copy link
Contributor

As far as I know, black is supported in Bash. Dark grey is fine too, anyway.

@MasterOdin
Copy link
Collaborator

As far as I know, black is supported in Bash. Dark grey is fine too, anyway.

This is a quirk of termcolor where it uses the name grey instead of black to represent ANSI code 30.

@zlatanvasovic
Copy link
Contributor

@KyleWJohnston Please review #95 and tell me does it solve some of your concerns.

@k4j8
Copy link
Author

k4j8 commented Apr 30, 2020

#96 implements improvements to light terminals that require different user modifications if any at all, making this PR unnecessary.

@k4j8 k4j8 closed this Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants