-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recommendations for light terminal themes #94
Conversation
Update the README to suggest a color configuration for light terminals themes. With the current default settings, the white text is not legible on most light terminal themes.
@@ -37,7 +38,17 @@ You can configure the behaviour and output of the `tldr` client by setting envir | |||
export TLDR_CACHE_ENABLED=1 | |||
export TLDR_CACHE_MAX_AGE=720 | |||
|
|||
For light terminal themes, the following colors are recommended: | |||
|
|||
export TLDR_COLOR_BLANK="yellow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not black though?
Good point. Although black wasn't an option, "grey dark" was. I tried the following code on all default light themes in Gnome Terminal and like it more. What do you think? If acceptable, I will modify and resubmit.
Black on light yellowBlack on whiteTango lightSolarized lightCurrent defaults (bad) - black on white |
As far as I know, |
This is a quirk of |
@KyleWJohnston Please review #95 and tell me does it solve some of your concerns. |
#96 implements improvements to light terminals that require different user modifications if any at all, making this PR unnecessary. |
Update the README to suggest a color configuration for light terminals themes. With the current default settings, the white text is not legible on most light terminal themes.