Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: partially revert #9672 because of misleading translations #12757

Closed
acuteenvy opened this issue May 7, 2024 · 0 comments · Fixed by #13458
Closed

Proposal: partially revert #9672 because of misleading translations #12757

acuteenvy opened this issue May 7, 2024 · 0 comments · Fixed by #13458
Labels
decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. mass changes Changes that affect multiple pages.

Comments

@acuteenvy
Copy link
Member

Because of a bug in set-alias-page.py (#12747), #9672 added a lot of misleading translations.
Since the issue has gone unnoticed for 2 years, fully reverting this commit would delete pages that have already been fixed. However, I would still suggest deleting all pages created there for languages without a CODEOWNER, because there's no one to take care of this mess. Once we make sure set-alias-page.py properly detects alias pages, we can readd them.
@acuteenvy acuteenvy added decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. mass changes Changes that affect multiple pages. labels May 7, 2024
acuteenvy added a commit to acuteenvy/tldr that referenced this issue Aug 17, 2024
@acuteenvy
Revert "pages.*: add standard translation (tldr-pages#9672)"
2f60864 
This partially reverts commit 5257568.
See tldr-pages#12757.
@acuteenvy acuteenvy mentioned this issue Aug 17, 2024
Merged
sebastiaanspeck pushed a commit that referenced this issue Aug 22, 2024
@acuteenvy
Revert "pages.*: add standard translation (#9672)" (#13458)
2e96d16 
This partially reverts commit 5257568.
See #12757.
@acuteenvy acuteenvy mentioned this issue Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. mass changes Changes that affect multiple pages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "pages.*: add standard translation (#9672)" acuteenvy/tldr
1 participant
@acuteenvy