Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-cloudformation: add page #10116

Merged
merged 4 commits into from May 16, 2023
Merged

aws-cloudformation: add page #10116

merged 4 commits into from May 16, 2023

Conversation

kxrtiswithak
Copy link
Contributor

@kxrtiswithak kxrtiswithak commented Apr 27, 2023 •
edited

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Apr 27, 2023
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/aws-cloudformation.md:32:115 MD047/single-trailing-newline Files should end with a single newline character
pages/common/aws-cloudformation.md:1: TLDR009 Page should contain a newline at end of file

Please fix the error(s) and push again.

@kbdharun kbdharun mentioned this pull request Apr 27, 2023
Open
@kxrtiswithak @kbdharun
Update pages/common/aws-cloudformation.md
d762f9e 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
pixelcmtd
pixelcmtd approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@pixelcmtd pixelcmtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the comment above has been addressed

@pixelcmtd pixelcmtd added the waiting Issues/PRs with Pending response by the author. label May 1, 2023
@github-actions github-actions bot removed the waiting Issues/PRs with Pending response by the author. label May 16, 2023
kbdharun
kbdharun approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun kbdharun merged commit f9b77c2 into tldr-pages:main May 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun approved these changes

@pixelcmtd pixelcmtd pixelcmtd approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kxrtiswithak @tldr-bot @kbdharun @pixelcmtd