Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soxi: add page #10938

Merged
merged 3 commits into from Oct 20, 2023
Merged

soxi: add page #10938

merged 3 commits into from Oct 20, 2023

Conversation

Njoselson
Copy link
Contributor

@Njoselson Njoselson commented Oct 11, 2023 •
edited

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 11, 2023
@Njoselson Njoselson changed the title adding soxi sound exchange info to tldr soxi: add page Oct 11, 2023
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/soxi.md:3: TLDR004 Command descriptions should end in a period
pages/common/soxi.md:6: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/soxi.md:9: TLDR008 File should contain no trailing whitespace

Please fix the error(s) and push again.

kbdharun
kbdharun reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have some suggestions for this page.

Note: We prefer manned links when the author's documentation link isn't present.

pages/common/soxi.md Outdated Show resolved Hide resolved
@Njoselson @kbdharun
Update pages/common/soxi.md
a60f8a7 
agreed!

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@Njoselson
Copy link
Contributor Author

Agreed! Thanks!

sebastiaanspeck
sebastiaanspeck approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kbdharun
kbdharun approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun kbdharun merged commit eee1abc into tldr-pages:main Oct 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Njoselson @CLAassistant @tldr-bot @sebastiaanspeck @kbdharun