Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws codeartifact: add page; pt_BR translation #11224

Merged
merged 1 commit into from Oct 26, 2023

Conversation

nkzren
Copy link
Contributor

@nkzren nkzren commented Oct 24, 2023

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): aws-cli/1.29.25 Python/3.11.5 Linux/6.1.59-1-lts botocore/1.31.25

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added new command Issues requesting creation of a new page. translation Translate pages from one language to another. labels Oct 24, 2023
@nkzren nkzren mentioned this pull request Oct 24, 2023
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/aws-codeartifact.md:4: TLDR014 Page should contain no trailing whitespace
pages/common/aws-codeartifact.md:7: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/aws-codeartifact.md:15: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/aws-codeartifact.md:16: TLDR007 Example descriptions should be surrounded by empty lines
pages.en/common/aws-codeartifact.md:4: TLDR014 Page should contain no trailing whitespace
pages.en/common/aws-codeartifact.md:16: TLDR007 Example descriptions should be surrounded by empty lines

Please fix the error(s) and push again.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/aws-codeartifact.md:7: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/aws-codeartifact.md:15: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/aws-codeartifact.md:16: TLDR007 Example descriptions should be surrounded by empty lines
pages.en/common/aws-codeartifact.md:16: TLDR007 Example descriptions should be surrounded by empty lines

Please fix the error(s) and push again.


- Recupera a URL do endpoint de um repositório do CodeArtifact:

`aws codeartifact get-repository-endpoint --domain {{your_domain}} --repository {{repository_name}} --format {{npm|pypi|maven|nuget|generic}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe translate those two parameters as well

@kbdharun kbdharun changed the title aws codeartifact: add page aws codeartifact: add page; pt_BR translation Oct 25, 2023
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Welcome to tldr and thanks for your contribution.

As mentioned by @sebastiaanspeck, I would suggest translating the application placeholders for domain, repository and subcommand.

@gutjuri
Copy link
Member

gutjuri commented Oct 26, 2023

Thanks for your contribution!

@gutjuri gutjuri merged commit d6d10d4 into tldr-pages:main Oct 26, 2023
4 checks passed
@kbdharun
Copy link
Member

kbdharun commented Oct 26, 2023

@gutjuri For PRs dealing with translations having code owners, it is suggested to wait for their reviews before merging it.

In this case, it's fine. If there are things to fix , the code owner can do it in a seperate PR.

@gutjuri
Copy link
Member

gutjuri commented Oct 26, 2023

Good to know, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page. translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants