Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

giftopnm: add page #11307

Merged
merged 10 commits into from
Oct 27, 2023
Merged

giftopnm: add page #11307

merged 10 commits into from
Oct 27, 2023

Conversation

iamanurag101
Copy link
Contributor

@iamanurag101 iamanurag101 commented Oct 27, 2023

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):
    issue Let's document: Netpbm #10887

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 27, 2023
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/giftopnm.md:
Error: Parse error on line 4:
...t/doc/giftopnm.html>- Converts a GIF i
-----------------------^
Expecting 'END_INFORMATION_LINK_URL', got 'NEWLINE'
pages/common/giftopnm.md:3: TLDR004 Command descriptions should end in a period
pages/common/giftopnm.md:4: TLDR011 Page never contains more than a single empty line
pages.en/common/giftopnm.md:
Error: Parse error on line 4:
...t/doc/giftopnm.html>- Converts a GIF i
-----------------------^
Expecting 'END_INFORMATION_LINK_URL', got 'NEWLINE'
pages.en/common/giftopnm.md:4: TLDR011 Page never contains more than a single empty line

Please fix the error(s) and push again.

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2023

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/giftopnm.md:
Error: Parse error on line 4:
...t/doc/giftopnm.html>- Converts a GIF i
-----------------------^
Expecting 'END_INFORMATION_LINK_URL', got 'NEWLINE'
pages/common/giftopnm.md:3: TLDR004 Command descriptions should end in a period
pages/common/giftopnm.md:4: TLDR011 Page never contains more than a single empty line
pages.en/common/giftopnm.md:
Error: Parse error on line 4:
...t/doc/giftopnm.html>- Converts a GIF i
-----------------------^
Expecting 'END_INFORMATION_LINK_URL', got 'NEWLINE'
pages.en/common/giftopnm.md:4: TLDR011 Page never contains more than a single empty line

Please fix the error(s) and push again.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/giftopnm.md:6: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/giftopnm.md:6: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)

Please fix the error(s) and push again.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/giftopnm.md:6: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)

Please fix the error(s) and push again.

Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! However, we have a style-guide for our pages: https://github.com/tldr-pages/tldr/blob/main/contributing-guides/style-guide.md
If you change the syntax for placeholders, and add examples showcasing the individual options, we can accept your PR. You can also have a look into other pages in order to get used to the style we use.

@iamanurag101
Copy link
Contributor Author

@gutjuri made the asked changes, can you please re-review my pr once, thank you

pages/common/giftopnm.md Outdated Show resolved Hide resolved
pages/common/giftopnm.md Outdated Show resolved Hide resolved
pages/common/giftopnm.md Outdated Show resolved Hide resolved
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Welcome to tldr and thanks for your contribution.

@kbdharun kbdharun merged commit d28304a into tldr-pages:main Oct 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants