Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brushtopbm: add page #11308

Merged
merged 5 commits into from
Oct 29, 2023
Merged

brushtopbm: add page #11308

merged 5 commits into from
Oct 29, 2023

Conversation

debghs
Copy link
Contributor

@debghs debghs commented Oct 27, 2023

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

Issue #10887

This adds brushtopbm page documentation.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 27, 2023
@kbdharun kbdharun mentioned this pull request Oct 27, 2023
Closed
gutjuri
gutjuri reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You! I have two minor suggestions.

pages/common/brushtopbm.md Outdated Show resolved Hide resolved
pages/common/brushtopbm.md Outdated Show resolved Hide resolved
debghs and others added 2 commits October 27, 2023 17:29
@debghs @gutjuri
Update pages/common/brushtopbm.md
9092bc0 
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
@debghs @gutjuri
Update pages/common/brushtopbm.md
46b309c 
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
@debghs
Copy link
Contributor Author

debghs commented Oct 27, 2023

I have committed the suggestions.

@debghs debghs closed this Oct 27, 2023
@debghs debghs reopened this Oct 27, 2023
gutjuri
gutjuri approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

Magrid0
Magrid0 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@Magrid0 Magrid0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your contribution!

(To be able to have your PR merged you need to sign the cla, thanks for understanding)

sebastiaanspeck
sebastiaanspeck requested changes Oct 27, 2023
View reviewed changes
pages/common/brushtopbm.md Outdated Show resolved Hide resolved
pixelcmtd
pixelcmtd approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@pixelcmtd pixelcmtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the comment above has been addressed

@gutjuri gutjuri merged commit 6bf06a2 into tldr-pages:main Oct 29, 2023
4 checks passed
@vitorhcl vitorhcl mentioned this pull request Feb 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@gutjuri gutjuri gutjuri approved these changes

@pixelcmtd pixelcmtd pixelcmtd approved these changes

@Magrid0 Magrid0 Magrid0 approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@debghs @sebastiaanspeck @gutjuri @pixelcmtd @Magrid0