Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-kafka: add page #11696

Merged
merged 27 commits into from
Dec 14, 2023
Merged

aws-kafka: add page #11696

merged 27 commits into from
Dec 14, 2023

Conversation

giladAlboher
Copy link
Contributor

@giladAlboher giladAlboher commented Dec 7, 2023

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Dec 7, 2023
@kbdharun kbdharun mentioned this pull request Dec 7, 2023
@kbdharun kbdharun changed the title aws-kafka: new page aws-kafka: add page Dec 7, 2023
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @giladAlboher for your contribution. I have a few review comments.
Place holders should be enclsed within {{ }} instead of < >
https://github.com/tldr-pages/tldr/blob/main/contributing-guides/style-guide.md

pages/common/aws-kafka.md Outdated Show resolved Hide resolved
pages/common/aws-kafka.md Outdated Show resolved Hide resolved
pages/common/aws-kafka.md Outdated Show resolved Hide resolved
pages/common/aws-kafka.md Outdated Show resolved Hide resolved
pages/common/aws-kafka.md Outdated Show resolved Hide resolved
pages/common/aws-kafka.md Outdated Show resolved Hide resolved
giladAlboher and others added 9 commits December 11, 2023 12:30
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@kbdharun kbdharun requested a review from mfrw December 13, 2023 06:49
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have some suggestions for this page.


A minor nitpick from my side, for descriptions I wouldn't suggest capitalizing successive terms unless it's required. i.e. Use Create a new MSK cluster instead of Create a New MSK Cluster.

pages/common/aws-kafka.md Outdated Show resolved Hide resolved
pages/common/aws-kafka.md Outdated Show resolved Hide resolved
pages/common/aws-kafka.md Outdated Show resolved Hide resolved
pages/common/aws-kafka.md Outdated Show resolved Hide resolved
pages/common/aws-kafka.md Outdated Show resolved Hide resolved
pages/common/aws-kafka.md Outdated Show resolved Hide resolved
pages/common/aws-kafka.md Outdated Show resolved Hide resolved
pages/common/aws-kafka.md Outdated Show resolved Hide resolved
pages/common/aws-kafka.md Outdated Show resolved Hide resolved
pages/common/aws-kafka.md Outdated Show resolved Hide resolved
giladAlboher and others added 10 commits December 13, 2023 12:55
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
giladAlboher and others added 2 commits December 13, 2023 14:00
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun kbdharun merged commit 5e2a144 into tldr-pages:main Dec 14, 2023
4 checks passed
@giladAlboher giladAlboher deleted the aws-kafka branch February 5, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants