Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy: add page #12024

Merged
merged 3 commits into from
Jan 8, 2024
Merged

tidy: add page #12024

merged 3 commits into from
Jan 8, 2024

Conversation

vitorhcl
Copy link
Member

@vitorhcl vitorhcl commented Jan 8, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Jan 8, 2024
@vitorhcl vitorhcl mentioned this pull request Jan 8, 2024
Open
47 tasks
sebastiaanspeck
sebastiaanspeck reviewed Jan 8, 2024
View reviewed changes
pages/common/tidy.md Show resolved Hide resolved
pages/common/tidy.md Outdated Show resolved Hide resolved
gutjuri
gutjuri approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the proposed suggestions. Thanks!

kbdharun
kbdharun reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. In addition to Sebastiaanspeck's suggestions, I have a few minor suggestions for this page.

pages/common/tidy.md Outdated Show resolved Hide resolved
pages/common/tidy.md Outdated Show resolved Hide resolved
vitorhcl and others added 2 commits January 8, 2024 11:26
@vitorhcl @sebastiaanspeck
tidy: add mnemonics
e5dda71 
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
@vitorhcl @kbdharun
tidy: replace config with configuration
03e1bdb 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@kbdharun kbdharun merged commit 0ff4322 into tldr-pages:main Jan 8, 2024
4 checks passed
@vitorhcl vitorhcl deleted the tidy branch January 8, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@gutjuri gutjuri gutjuri approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vitorhcl @sebastiaanspeck @gutjuri @kbdharun