Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-sns: add page #12259

Merged
merged 3 commits into from Feb 14, 2024
Merged

aws-sns: add page #12259

merged 3 commits into from Feb 14, 2024

Conversation

vitorhcl
Copy link
Member

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 2.15.19

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Feb 14, 2024
@tldr-bot

This comment was marked as resolved.

Sign in to view
@vitorhcl vitorhcl mentioned this pull request Feb 14, 2024
Open
gutjuri
gutjuri reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have two suggestions

pages/common/aws-sns.md Outdated Show resolved Hide resolved
pages/common/aws-sns.md Outdated Show resolved Hide resolved
@vitorhcl @gutjuri
aws-sns: fix verb tense and remove additional pipe
fc46308 
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
@sebastiaanspeck sebastiaanspeck merged commit 730294d into tldr-pages:main Feb 14, 2024
4 checks passed
@vitorhcl vitorhcl deleted the aws-sns-add-page branch February 14, 2024 21:24
sebastiaanspeck pushed a commit to sebastiaanspeck/tldr that referenced this pull request Feb 15, 2024
@vitorhcl @gutjuri @sebastiaanspeck
aws-sns: add page (tldr-pages#12259)
4b20c52 
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gutjuri gutjuri gutjuri left review comments

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vitorhcl @tldr-bot @sebastiaanspeck @gutjuri @kbdharun