Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpx: add page #12279

Merged
merged 8 commits into from Feb 17, 2024
Merged

httpx: add page #12279

merged 8 commits into from Feb 17, 2024

Conversation

fazlearefin
Copy link
Member

@fazlearefin fazlearefin commented Feb 15, 2024 •
edited

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Feb 15, 2024
vitorhcl
vitorhcl requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this excellent PR! I have some suggestions

pages/common/httpx.md Outdated Show resolved Hide resolved
pages/common/httpx.md Outdated Show resolved Hide resolved
pages/common/httpx.md Outdated Show resolved Hide resolved
pages/common/httpx.md Outdated Show resolved Hide resolved
pages/common/httpx.md Outdated Show resolved Hide resolved
pages/common/httpx.md Outdated Show resolved Hide resolved
pages/common/httpx.md Outdated Show resolved Hide resolved
pages/common/httpx.md Outdated Show resolved Hide resolved
fazlearefin and others added 6 commits February 16, 2024 14:42
@fazlearefin @vitorhcl
Update pages/common/httpx.md
0bc8fb6 
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin @vitorhcl
Update pages/common/httpx.md
97d87f0 
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin @vitorhcl
Update pages/common/httpx.md
90748f9 
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin @vitorhcl
Update pages/common/httpx.md
8c815ca 
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin @vitorhcl
Update pages/common/httpx.md
3cd32ea 
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin
httpx: edit example conforming to tldr style guide
55b3e3c
kbdharun
kbdharun approved these changes Feb 16, 2024
View reviewed changes
pages/common/httpx.md Outdated Show resolved Hide resolved
fazlearefin
fazlearefin commented Feb 16, 2024
View reviewed changes
pages/common/httpx.md Outdated Show resolved Hide resolved
@vitorhcl vitorhcl changed the title httpx: add new command httpx: add page Feb 16, 2024
@fazlearefin @vitorhcl
Update pages/common/httpx.md
c3a4729 
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin fazlearefin merged commit aee00f3 into main Feb 17, 2024
8 checks passed
@fazlearefin fazlearefin deleted the feature/httpx branch February 17, 2024 04:14
@fazlearefin fazlearefin mentioned this pull request Feb 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gutjuri gutjuri gutjuri approved these changes

@kbdharun kbdharun kbdharun approved these changes

@vitorhcl vitorhcl vitorhcl approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fazlearefin @gutjuri @kbdharun @vitorhcl