Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tunelp: add page #12542

Merged
merged 2 commits into from
Mar 27, 2024
Merged

tunelp: add page #12542

merged 2 commits into from
Mar 27, 2024

Conversation

vitorhcl
Copy link
Member

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): util-linux 2.39.3

@vitorhcl vitorhcl requested a review from cyqsimon as a code owner March 23, 2024 13:37
@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Mar 23, 2024
kbdharun
kbdharun approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

einverne
einverne approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

gutjuri
gutjuri reviewed Mar 24, 2024
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have some suggestions.

pages/linux/tunelp.md Outdated Show resolved Hide resolved
pages/linux/tunelp.md Outdated Show resolved Hide resolved
pages/linux/tunelp.md Outdated Show resolved Hide resolved
pages/linux/tunelp.md Outdated Show resolved Hide resolved
@vitorhcl vitorhcl mentioned this pull request Mar 25, 2024
Open
@kbdharun @gutjuri
tunelp: wrap parallel port inside placeholder
7fc7057 
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
@kbdharun kbdharun merged commit 1108517 into tldr-pages:main Mar 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gutjuri gutjuri gutjuri left review comments

@einverne einverne einverne approved these changes

@kbdharun kbdharun kbdharun approved these changes

@cyqsimon cyqsimon Awaiting requested review from cyqsimon cyqsimon is a code owner

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vitorhcl @einverne @gutjuri @kbdharun