Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsx: add page #12618

Merged
merged 8 commits into from Apr 11, 2024
Merged

dnsx: add page #12618

merged 8 commits into from Apr 11, 2024

Conversation

fazlearefin
Copy link
Member

@fazlearefin fazlearefin commented Apr 7, 2024 •
edited

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Apr 7, 2024
vitorhcl
vitorhcl reviewed Apr 7, 2024
View reviewed changes
pages/common/dnsx.md Outdated Show resolved Hide resolved
pages/common/dnsx.md Outdated Show resolved Hide resolved
pages/common/dnsx.md Outdated Show resolved Hide resolved
pages/common/dnsx.md Outdated Show resolved Hide resolved
pages/common/dnsx.md Outdated Show resolved Hide resolved
fazlearefin and others added 3 commits April 8, 2024 09:12
@fazlearefin @vitorhcl
Update pages/common/dnsx.md
f40f569 
Co-authored-by: Vítor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin @vitorhcl
Update pages/common/dnsx.md
3f57d93 
Co-authored-by: Vítor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin
dnsx: remove word FUZZ from example description
bde235a
@fazlearefin fazlearefin mentioned this pull request Apr 8, 2024
Open
kbdharun
kbdharun approved these changes Apr 8, 2024
View reviewed changes
pages/common/dnsx.md Outdated Show resolved Hide resolved
@fazlearefin @kbdharun
Update pages/common/dnsx.md
a530008 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@kbdharun kbdharun requested a review from vitorhcl April 10, 2024 07:56
vitorhcl
vitorhcl approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding suggestions to tools related to DNS.

pages/common/dnsx.md Show resolved Hide resolved
@fazlearefin @vitorhcl
Update pages/common/dnsx.md
ab4128b 
Co-authored-by: Vítor Henrique <87824454+vitorhcl@users.noreply.github.com>
einverne
einverne approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@einverne einverne merged commit 771b944 into tldr-pages:main Apr 11, 2024
4 checks passed
@fazlearefin fazlearefin deleted the feature/dnsx branch April 11, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorhcl vitorhcl vitorhcl approved these changes

@einverne einverne einverne approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fazlearefin @einverne @kbdharun @vitorhcl