Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-tag: add example on how to push a tag #13079

Merged
merged 3 commits into from
Jun 20, 2024
Merged

git-tag: add example on how to push a tag #13079

merged 3 commits into from
Jun 20, 2024

Conversation

ZeroOne3010
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

I think this is a pretty crucial piece of information on how you use tags in Git.

@CLAassistant
Copy link

CLAassistant commented Jun 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the page edit Changes to an existing page(s). label Jun 19, 2024
vitorhcl
vitorhcl previously requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Isn't remote a better term? Upstream is also used for forks.

LGTM after this issue is addressed.

pages/common/git-tag.md Outdated Show resolved Hide resolved
pages/common/git-tag.md Show resolved Hide resolved
@kbdharun kbdharun changed the title git-tag: Add example on how to push a tag git-tag: add example on how to push a tag Jun 20, 2024
kbdharun
kbdharun approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to tldr and thanks for your contribution.

LGTM, after the above suggestions.

@ZeroOne3010
Copy link
Contributor Author

Isn't remote a better term? Upstream is also used for forks.

Yes, good point, of course! I just copied the term from the other example without stopping to think. 🤦 I've changed both of them now!

spageektti
spageektti reviewed Jun 20, 2024
View reviewed changes
pages/common/git-tag.md Outdated Show resolved Hide resolved
@spageektti spageektti dismissed vitorhcl’s stale review June 20, 2024 16:32

requested changes have been made

@spageektti
Copy link
Member

Thanks for your contribution @ZeroOne3010. Can you please check my suggestion so we can merge this PR?

@spageektti spageektti merged commit 674f475 into tldr-pages:main Jun 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spageektti spageektti spageektti approved these changes

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@kbdharun kbdharun kbdharun approved these changes

@vitorhcl vitorhcl Awaiting requested review from vitorhcl

Assignees
No one assigned
Labels
page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ZeroOne3010 @CLAassistant @spageektti @sebastiaanspeck @kbdharun @vitorhcl