Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logwatch: add page #1311

Merged
merged 4 commits into from May 24, 2017
Merged

logwatch: add page #1311

merged 4 commits into from May 24, 2017

Conversation

kalebo
Copy link
Contributor

@kalebo kalebo commented Mar 27, 2017

Logwatch is a useful command to summarize log files. It can be configured to use settings from it's config file and run by cron, but it can also be useful to run ad-hoc from the command line.

Logwatch is a useful command to summarize log files. It can be configured to use settings from it's config file and run by cron, but it can also be useful to run ad-hoc from the command line.
@agnivade agnivade added the new command Issues requesting creation of a new page. label Mar 27, 2017
@@ -0,0 +1,11 @@
# logwatch

> Analyzes and summarizes system logs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "system" mean here ? syslog ? Or any application log ? If its the latter, where is the location specified ?


- Analyze yesterday's logs in medium detail:

`logwatch --range yesterday --detail med`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesterday and med to be in tokens.


- Get the summarized login information for the last 3 weeks:

`logwatch --range 'since 3 weeks ago' --detail low --service pam_unix `
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use tokens for the 3 options. And I think, instead of specifying med and low in separate examples, maybe you can mention 'in a given detail' in the description and write '--details {{low|medium|others}}' in the example. A shorter and concise way to express more.

@agnivade agnivade added the waiting Issues/PRs with Pending response by the author. label Apr 3, 2017
@stale stale bot closed this May 1, 2017
@stale
Copy link

stale bot commented May 1, 2017

Hi everyone. This thread is being closed as there was no response to the previous prompt. However, please leave a comment whenever you're ready to resume, so the thread can be reopened. Thanks again!

@waldyrious
Copy link
Member

Reopening as the "previous prompt" wasn't provided by @probot-stale. Please see #1350 and #1360 for details.

@waldyrious waldyrious reopened this May 1, 2017
@stale stale bot removed the waiting Issues/PRs with Pending response by the author. label May 1, 2017
* rewrote tagline
* used tokens in first example
* reduced the number of examples
@kalebo
Copy link
Contributor Author

kalebo commented May 2, 2017

@agnivade I addressed the issues you mentioned in the review; however, I'm not sure how to make the commit I just added to switch the issue status from "Changes requested" back to "Needing Review".

@waldyrious
Copy link
Member

@kalebo I don't think github does that, though indeed it should (the reviewing flow will most likely have these rough edges polished over time). In any case, @agnivade will probably take a look soon :)


`logwatch --range yesterday --detail med`

- Get the summarized login information for the last 3 weeks:
Copy link
Member

@agnivade agnivade May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the --service flag is a useful one. In case someone wants to get logs of a particular service. Let's keep that one.

@@ -1,11 +1,7 @@
# logwatch

> Analyzes and summarizes system logs.
> Summarizes many different logs for common services (e.g., apache, SSHD, etc.) in single report.
Copy link
Member

@agnivade agnivade May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. in single report -> in a single report.
  2. SSHD -> sshd. (True that its an acronym, but just like tcp, I think its more familiar in its lowercase form)

Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some minor comments to take care of.

@waldyrious
Copy link
Member

Ping @kalebo :) (let us know you feel we're being unreasonably picky, or have any other concerns -- we're still learning the kinks of properly maintaining such a highly collaborative project).

@waldyrious waldyrious merged commit 4e544c1 into tldr-pages:master May 24, 2017
@waldyrious
Copy link
Member

Thanks for the contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants