create configuration file for probot-stale #1360
Conversation
as discussed in #1350.
.github/stale.yml
Outdated
| # Configuration for probot-stale - https://github.com/probot/stale | ||
|
|
||
| # Number of days of inactivity before an issue or PR is considered stale | ||
| daysUntilStale: 30 |
.github/stale.yml
Outdated
| # Comment to post when marking an issue or PR as stale | ||
| markComment: > | ||
| Hi all! This thread has not had any recent activity. | ||
| Can anyone comment on what's blocking progress? |
There was a problem hiding this comment.
This line feels a bit weird. I would rather change it to "Any updates on this ?'
There was a problem hiding this comment.
How about "Are there any updates?"
What I like about the initial version is that it makes a specific call to action rather than placing a generic question. But it's not a big deal, and we can tweak the message later if we can find a way to combine the advantages of both sentences.
There was a problem hiding this comment.
How about "Are there any updates?"
looks good.
There was a problem hiding this comment.
Any comments on the call to action part?
There was a problem hiding this comment.
I mean I don't see that the new version is not a call to action in any way. Its not direct, that's true. And I would rather not be too direct. The new version seems to have the right tonality and still ask for some work to be done in a friendly way.
.github/stale.yml
Outdated
| daysUntilStale: 30 | ||
|
|
||
| # Number of days of inactivity before a stale issue or PR is closed | ||
| daysUntilClose: 30 |
There was a problem hiding this comment.
Is this absolute, or days after daysUntilStale?
There was a problem hiding this comment.
The later. Its mentioned before a stale issue
|
I have a question though. Lets say a PR becomes stale, the bot marks it as such. Then someone comments on it. Will the bot remove the label "stale" ? Logic suggests that it should, otherwise it doesn't make sense that when the PR becomes stale again for the 2nd time, it can't re-label something when its already labelled. |
|
@agnivade yes, it does remove the label -- the example I pointed out in #1350 shows this in action:
|
|
Alright! let's try this out :) |
|
Ok, this is now installed, as can be confirmed in https://github.com/organizations/tldr-pages/settings/installations. Let's see how it goes. |
|
So this just works? We don't need to add the functionality to the upcoming bot for this? |
|
Not if the way this works is sufficient for our needs :) |
So this is my proposal for configurations to use in our probot-stale integration, as discussed in #1350.
Any feedback about the time periods, messages, or other details of the configuration? /cc @agnivade @Ostera @jeeftor @sbrl @igorshubovych @rubenvereecken.
Note: merging this won't automatically enable probot-stale on this repo; we'll need to activate it in https://github.com/integration/probot-stale.