ember: Add ember build -prod command
#1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
agnivade
approved these changes
Dec 8, 2017
There was a problem hiding this comment.
Looks okay to me. But please wait for @alexlafroscia's review.
|
Fine by me! As long as there aren't too many examples, I know the target is like 5-7 and we're pushing the upper limit on that. |
alexlafroscia
approved these changes
Dec 8, 2017
|
The max limit is 8. With this example, it touches that. We don't usually reach the limit unless for a good reason. I think building for prod is a good enough reason. |
|
Thanks, @Turbo87 and @alexlafroscia 😺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page (if new), does not already exist in the repo.The page (if new), has been added to the correct platform folder:
common/if it's common to all platforms,linux/if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add pagefor new pages, or<command name>: <description of changes>for pages being editedThe page follows the contributing guidelines
/cc @alexlafroscia