Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert: add example for creating a gif #2235

Merged
merged 4 commits into from
Aug 8, 2018
Merged

convert: add example for creating a gif #2235

merged 4 commits into from
Aug 8, 2018

Conversation

ShaunKarran
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

tldr-bot commented Aug 7, 2018

The build for this PR has failed with the following error(s):

Error: Parse error on line 23:
... series of images: `convert {{image1.p...
---------------------^
Expecting 'BACKTICK', got 'TEXT'

Please fix the error(s) and push again.

agnivade
agnivade requested changes Aug 7, 2018
View reviewed changes
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Got a couple of minor comments.

pages/common/convert.md Outdated
@@ -17,3 +17,7 @@
- Horizontally append images:

`convert {{image1.png}} {{image2.png}} {{image3.png}} +append {{image123.png}}`

- Create gif from series of images:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a gif from a series of images with a given delay in (unit?) between them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome example! I can see this being really handy. Much simpler than ffmpeg!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments! :)

pages/common/convert.md Outdated

- Create gif from series of images:

`convert {{image1.png}} {{image2.png}} {{image3.png}} -delay 100 {{animation.gif}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100 in tokens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other examples set a specific value for the purpose of the example. I was following that format.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we prefer specific values in examples. I just want the value to be in tokens.

@owenvoke owenvoke merged commit 87cf0ae into tldr-pages:master Aug 8, 2018
@owenvoke owenvoke added the page edit Changes to an existing page(s). label Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrl sbrl sbrl left review comments

@agnivade agnivade agnivade approved these changes

@owenvoke owenvoke owenvoke approved these changes

Assignees
No one assigned
Labels
page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ShaunKarran @CLAassistant @tldr-bot @agnivade @owenvoke @sbrl