Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dot: fix typo #2493

Merged
merged 1 commit into from
Oct 28, 2018
Merged

dot: fix typo #2493

merged 1 commit into from
Oct 28, 2018

Conversation

mcbloch
Copy link

@mcbloch mcbloch commented Oct 25, 2018

fix typing error


  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited.

  • The page follows the contributing guidelines.

fix typing error
@CLAassistant
Copy link

CLAassistant commented Oct 25, 2018

CLA assistant check
All committers have signed the CLA.

@mfrw mfrw added the page edit Changes to an existing page(s). label Oct 25, 2018
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many commands actually do not bother if there is no space after a flag. But anyways, it's good to be clear.

@sbrl
Copy link
Member

sbrl commented Oct 26, 2018

Hey, thanks for the change @maximebloch! The lack of a space here was probably intentional. Does this command still work with a space? If so, I'd definitely advocate this change, as it makes the page clearer :-)

@sbrl sbrl merged commit 3996a17 into tldr-pages:master Oct 28, 2018
@mcbloch
Copy link
Author

mcbloch commented Oct 29, 2018

Thanks, I did not know that flags without spacing are a thing. I just checked and the command does work without and without the space.
Thanks for merging :)

@mcbloch mcbloch deleted the patch-1 branch October 29, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants