Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria2c: add new example #2515

Merged
merged 2 commits into from
Oct 29, 2018
Merged

Conversation

miguendes
Copy link


  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited.

  • The page follows the contributing guidelines.

@tldr-bot
Copy link

The build for this PR has failed with the following error(s):

pages/common/aria2c.md:26: TLDR005 Example descriptions should end in a colon

Please fix the error(s) and push again.

@sbrl sbrl added the page edit Changes to an existing page(s). label Oct 28, 2018
@sbrl
Copy link
Member

sbrl commented Oct 28, 2018

Hey - thanks for the edit, @mendesmiguel! Looks like you're having some issues with the linter. We've got the style we prefer documented over here, and a few good examples are the pages for tar, eyeD3, and ln. If you need any assistance, just ask 😺

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mendesmiguel 😺

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mendesmiguel

@owenvoke owenvoke merged commit 840d3f2 into tldr-pages:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants