Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pages.zh/osx: add Chinese translation #2796

Merged
merged 36 commits into from
Feb 26, 2019
Merged

pages.zh/osx: add Chinese translation #2796

merged 36 commits into from
Feb 26, 2019

Conversation

wizarot
Copy link
Contributor

@wizarot wizarot commented Feb 22, 2019

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.

@CLAassistant
Copy link

CLAassistant commented Feb 22, 2019

CLA assistant check
All committers have signed the CLA.

@agnivade
Copy link
Member

@wizarot - Thank you for the contribution !

Kindly rename your commit msgs in the format of ": add Chinese translation". And also please remove the merge commit from between so that we can rebase all the commits to master.

Feel free to ask @mebeim for any sort of git help 😝

@wizarot wizarot force-pushed the tldr-zh branch 3 times, most recently from 4d51515 to af6ee52 Compare February 22, 2019 07:57
@wizarot
Copy link
Contributor Author

wizarot commented Feb 22, 2019

@wizarot - Thank you for the contribution !

Kindly rename your commit msgs in the format of ": add Chinese translation". And also please remove the merge commit from between so that we can rebase all the commits to master.

Feel free to ask @mebeim for any sort of git help 😝

@agnivade
I revised it. Is that OK?

@agnivade
Copy link
Member

It's not actually. Sorry if I was not able to explain. I want each page translation to have its own commit. And there should not be any merge commit in the branch.

What you have currently is also "okay", but we prefer to have a separate commit for each page to keep things clean.

@owenvoke owenvoke added the translation Translate pages from one language to another. label Feb 22, 2019
@@ -0,0 +1,24 @@
# apache2ctl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm. Did you mean to translate this page? It looks like English to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it !

@wizarot wizarot changed the title <translation>: (pages.zh/osx) <add Chinses translation for osx> pages.zh/osx: add Chinses translation Feb 23, 2019
@wizarot
Copy link
Contributor Author

wizarot commented Feb 23, 2019

Hi! I changed each page translation to its own commit.
@agnivade

@agnivade agnivade changed the title pages.zh/osx: add Chinses translation pages.zh/osx: add Chinese translation Feb 23, 2019
@agnivade
Copy link
Member

agnivade commented Feb 23, 2019

The commits look good. /cc @HugueLiu

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @wizarot!

@HugueLiu
Copy link
Contributor

The contents in {{}} should also be translated. @wizarot

@mebeim mebeim self-requested a review February 24, 2019 03:49
@mebeim
Copy link
Member

mebeim commented Feb 24, 2019

@HugueLiu oh you're right, we totally missed that.

@urbalazs
Copy link
Contributor

Hello @wizarot and others,
IMHO creation of translated pages manually is waste of time now. I have a pull request with a proposal for translation workflow. I suggest to move your translations to a .po file in i18n folder (not exists yet) called i18n/tldr.zh.po and let generate translated pages with my script located in #2793. See this pull request for more details. You can find a .pot file in the mentioned PR.

With this workflow:

  • translated pages can be easy maintainable
  • translators will be notified about string changes in the source
  • can be generate more output (PDF, EPUB, etc.) if needed

@agnivade
Copy link
Member

Yes, it may require extra work to move translations to a .po file. But since the author already has put effort in submitting a PR, I think that should be respected. We can always move to the po4a workflow when it's ready, but until then, I don't see a reason to block all translations.

@urbalazs
Copy link
Contributor

I can help to move existing translations to .po files, if the final decision will be made to use .po for translations. There are some command line tool for this and I have experiences about its usage.

@agnivade
Copy link
Member

That's great @urbalazs ! Thanks for helping us out with this. The final decision is indeed to use .po files. But since this is a new workflow, one of us need to own and understand it. @mebeim has graciously offered to lead this, but he needs some time. Let us continue with the existing workflow until then.

@wizarot
Copy link
Contributor Author

wizarot commented Feb 26, 2019

I translated the contents in {{}} . @HugueLiu

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @wizarot 😺

@sbrl sbrl merged commit 8d90e79 into tldr-pages:master Feb 26, 2019
Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants