-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize project name #4035
Harmonize project name #4035
Conversation
I don't have any strong opinions. tldr-pages looks fine to me. |
Marked this as a draft to ensure it isn't merged until we make a decision. @zdroid does your approval mean you are OK with me changing to tldr-pages (with hyphen), as I mentioned above? |
I'm approving any change that standardizes the project's name. Either work fine. Perhaps |
@waldyrious, I am totally agree with changing to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I think tldr-pages
is better than tldr pages
as a brand name.
Alright, I'll make the change to |
This is now ready for review, but I'd like your input about related changes that I held off making yet: should we also rename the following items?
I suppose they should mostly be safe except perhaps the tldr.zip filename, but do let me know if I'm missing something regarding the other two. Also: when merging, please use the rebase method so that the formatting tweaks commit isn't mixed up with the name standardization one. |
|
@waldyrious tldr-pages.github.io should be updated too. I tried to do a part of the job in tldr-pages/tldr-pages.github.io@43a767b. |
@waldyrious indeed the ZIP filename is pretty hard to rename. Many clients use it and renaming it would definitely break those. We could keep it as is and it also kind of makes sense to me since the client programs are always named |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, @waldyrious 😺
@waldyrious Those includes are alright. |
@waldyrious oh sorry I slipped over them, those are fine to me :) |
Alright, I've added the two renames mentioned above. Ready to merge at your discretion! (ps - make sure to use the "rebase" option to keep the unrelated cleanup commit separate from the name normalization one) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, looks great to me! Thanks, @waldyrious 😺
Geronimo! |
Follow-up of #1109, in particular of this comment.
I've already updated/renamed the wiki pages (see here, here and here).
If I may add: now that I went through all the places where we used "tldr-pages" (with hyphen) and replaced them with "tldr pages" (with a space), I am now convinced that removing the hyphen is a the wrong direction to do the normalization, as it makes all the phrases where the project name appears more ambiguous. A good brand/name should achieve, if anything, the opposite!
Considering that the discussion in #1109 actually never produced a clear decision regarding the hyphenization of the project name (it was merely a no-consensus, as described here), I'm inclined to make the reverse change in this PR, i.e. normalize everything towards tldr-pages. I'll wait for others to chime in before doing so, but please review the diff of commit ca3cca5 to inform your comments.