Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-kinesis: add page #4510

Merged
merged 5 commits into from Oct 12, 2020
Merged

Conversation

mearns
Copy link
Contributor

@mearns mearns commented Oct 5, 2020

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please take a look at the comments.

pages/common/aws-kinesis.md Outdated Show resolved Hide resolved
pages/common/aws-kinesis.md Outdated Show resolved Hide resolved
@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Oct 6, 2020
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


- Write one record to a Kinesis stream:

`aws kinesis put-record --stream-name {{streamname}} --partition-key {{partition_key}} --data {{base64_encoded_message}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use just name because the argument has -name, it's easy to read:

Suggested change
`aws kinesis put-record --stream-name {{streamname}} --partition-key {{partition_key}} --data {{base64_encoded_message}}`
`aws kinesis put-record --stream-name {{name}} --partition-key {{partition_key}} --data {{base64_encoded_message}}`

Or

Suggested change
`aws kinesis put-record --stream-name {{streamname}} --partition-key {{partition_key}} --data {{base64_encoded_message}}`
`aws kinesis put-record --stream-name {{stream_name}} --partition-key {{partition_key}} --data {{base64_encoded_message}}`

The same for the other examples with --stream-name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, updated in 669be42. I applied the same to the other parameters, like changing --partition-key {{partition_key}} to --partition-key {{key}}. I can change those back if you prefer.

@navarroaxel navarroaxel merged commit 7fcea61 into tldr-pages:master Oct 12, 2020
@kbdharun kbdharun mentioned this pull request Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants