New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-kinesis: add page #4510
aws-kinesis: add page #4510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Please take a look at the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
pages/common/aws-kinesis.md
Outdated
|
||
- Write one record to a Kinesis stream: | ||
|
||
`aws kinesis put-record --stream-name {{streamname}} --partition-key {{partition_key}} --data {{base64_encoded_message}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use just name
because the argument has -name
, it's easy to read:
`aws kinesis put-record --stream-name {{streamname}} --partition-key {{partition_key}} --data {{base64_encoded_message}}` | |
`aws kinesis put-record --stream-name {{name}} --partition-key {{partition_key}} --data {{base64_encoded_message}}` |
Or
`aws kinesis put-record --stream-name {{streamname}} --partition-key {{partition_key}} --data {{base64_encoded_message}}` | |
`aws kinesis put-record --stream-name {{stream_name}} --partition-key {{partition_key}} --data {{base64_encoded_message}}` |
The same for the other examples with --stream-name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, updated in 669be42. I applied the same to the other parameters, like changing --partition-key {{partition_key}}
to --partition-key {{key}}
. I can change those back if you prefer.
common/
,linux/
, etc.)