Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-ec2: add page #4661

Merged
merged 1 commit into from Oct 12, 2020
Merged

aws-ec2: add page #4661

merged 1 commit into from Oct 12, 2020

Conversation

eshack94
Copy link
Contributor

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/aws-ec2.md:26: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)

Please fix the error(s) and push again.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/aws-ec2.md:26: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)

Please fix the error(s) and push again.

@mebeim mebeim added the new command Issues requesting creation of a new page. label Oct 12, 2020
@navarroaxel navarroaxel changed the title aws ec2: Add entry aws-ec2: add page Oct 12, 2020
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eshack94, just a few comments

pages/common/aws-ec2.md Outdated Show resolved Hide resolved
pages/common/aws-ec2.md Outdated Show resolved Hide resolved
pages/common/aws-ec2.md Outdated Show resolved Hide resolved
pages/common/aws-ec2.md Outdated Show resolved Hide resolved
pages/common/aws-ec2.md Outdated Show resolved Hide resolved
pages/common/aws-ec2.md Outdated Show resolved Hide resolved
pages/common/aws-ec2.md Outdated Show resolved Hide resolved
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @eshack94!

@sbrl sbrl merged commit 6b248c8 into tldr-pages:master Oct 12, 2020
@kbdharun kbdharun mentioned this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants