Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-lambda: add page #4774

Merged
merged 5 commits into from
Oct 28, 2020
Merged

aws-lambda: add page #4774

merged 5 commits into from
Oct 28, 2020

Conversation

honarmand-io
Copy link
Contributor

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/aws-lambda.md:3: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

@navarroaxel navarroaxel changed the title Aws lambda add page aws-lambda: add page Oct 20, 2020
@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Oct 20, 2020
navarroaxel
navarroaxel requested changes Oct 20, 2020
View reviewed changes
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @honarmand-io, I left some comments.

pages/common/aws-lambda.md Outdated Show resolved Hide resolved
pages/common/aws-lambda.md Outdated Show resolved Hide resolved
pages/common/aws-lambda.md Outdated Show resolved Hide resolved
pages/common/aws-lambda.md Outdated Show resolved Hide resolved
pages/common/aws-lambda.md Outdated Show resolved Hide resolved
pages/common/aws-lambda.md Outdated Show resolved Hide resolved
pages/common/aws-lambda.md Outdated Show resolved Hide resolved
pages/common/aws-lambda.md Outdated Show resolved Hide resolved
navarroaxel
navarroaxel requested changes Oct 24, 2020
View reviewed changes
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 space.

pages/common/aws-lambda.md Outdated

- Display the configuration of a function:

`aws lambda get-function-configuration --function-name {{name}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`aws lambda get-function-configuration --function-name {{name}}`
`aws lambda get-function-configuration --function-name {{name}}`

@sbrl sbrl added the hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. label Oct 28, 2020
sbrl
sbrl approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @honarmand-io!

@sbrl sbrl merged commit 4e011ef into tldr-pages:master Oct 28, 2020
@kbdharun kbdharun mentioned this pull request Apr 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@honarmand-io @tldr-bot @navarroaxel @sbrl @ahonarmand