Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-stripspace: add page #5094

Merged
merged 4 commits into from
Jan 7, 2021
Merged

git-stripspace: add page #5094

merged 4 commits into from
Jan 7, 2021

Conversation

bl-ue
Copy link
Contributor

@bl-ue bl-ue commented Jan 6, 2021 •
edited
Loading

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For #3953

@bl-ue bl-ue added the new command Issues requesting creation of a new page. label Jan 6, 2021
@bl-ue bl-ue mentioned this pull request Jan 6, 2021
Open
bl-ue
bl-ue commented Jan 6, 2021
View reviewed changes
pages/common/git-stripspace.md Outdated Show resolved Hide resolved
sbrl
sbrl reviewed Jan 7, 2021
View reviewed changes
pages/common/git-stripspace.md Outdated Show resolved Hide resolved
pages/common/git-stripspace.md Outdated Show resolved Hide resolved
bl-ue and others added 2 commits January 6, 2021 21:08
@bl-ue @sbrl
Update pages/common/git-stripspace.md
842f1db 
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@bl-ue @sbrl
Update pages/common/git-stripspace.md
a552e46 
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@bl-ue bl-ue requested review from sbrl and schneiderl January 7, 2021 03:24
schneiderl
schneiderl approved these changes Jan 7, 2021
View reviewed changes
Copy link
Collaborator

@schneiderl schneiderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea this existed. Nice!

schneiderl
schneiderl requested changes Jan 7, 2021
View reviewed changes
Copy link
Collaborator

@schneiderl schneiderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I've just seen this.

pages/common/git-stripspace.md Outdated Show resolved Hide resolved
pages/common/git-stripspace.md Outdated Show resolved Hide resolved
@bl-ue @schneiderl
Apply suggestions from code review
3409f1c 
Co-authored-by: Lucas Gabriel Schneider <casdpa@gmail.com>
sbrl
sbrl approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bl-ue!

@sbrl sbrl merged commit db6ccdc into master Jan 7, 2021
@sbrl sbrl deleted the git/stripspace branch January 7, 2021 21:49
@bl-ue
Copy link
Contributor Author

bl-ue commented Jan 7, 2021

Oops! I tried to delete that branch at the same time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrl sbrl sbrl approved these changes

@schneiderl schneiderl schneiderl approved these changes

@navarroaxel navarroaxel Awaiting requested review from navarroaxel

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bl-ue @sbrl @schneiderl