Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLIENT-SPECIFICATION: add macos recommendation #7514

Merged
merged 4 commits into from Feb 17, 2022
Merged

Conversation

MasterOdin
Copy link
Collaborator

  • The PR title conforms to the recommended templates.

Closes #7076. This adds to the specification that it's recommended to treat macos as an alias for osx. At some point it might be good to migrate to macos for folder structure, this at least is a step in that direction.

Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
@github-actions github-actions bot added the documentation Issues/PRs modifying the documentation. label Dec 6, 2021
@navarroaxel navarroaxel changed the title CLIENT-SPECIFICATION: Add macos recommendation CLIENT-SPECIFICATION: add macos recommendation Dec 6, 2021
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me! This will be a long process to rename osx to macos I'm sure, but it's great to take the first step towards that here.

Could we update the client specification changelog (at the bottom of the file) for this too please?

@MasterOdin
Copy link
Collaborator Author

@sbrl I've updated the changelog at the bottom, but did you want me to set the version to 1.6 throughout, or will that happen in its own PR (like other version releases)?

CLIENT-SPECIFICATION.md Outdated Show resolved Hide resolved
CLIENT-SPECIFICATION.md Outdated Show resolved Hide resolved
@sbrl
Copy link
Member

sbrl commented Dec 21, 2021

Regarding the version number bump, I can open a PR for that when we have #7561 merged, as that should make it into v1.6 I think.

I'll also write a release when that's done.

@CleanMachine1
Copy link
Member

whoops, reviewed twice!

@MasterOdin MasterOdin requested a review from sbrl January 9, 2022 18:46
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Jan 25, 2022
@MasterOdin MasterOdin added review needed Prioritized PRs marked for reviews from maintainers. and removed waiting Issues/PRs with Pending response by the author. labels Jan 25, 2022
@MasterOdin
Copy link
Collaborator Author

Friendly bump @sbrl!

@MasterOdin MasterOdin merged commit 3c3649e into main Feb 17, 2022
@MasterOdin MasterOdin deleted the MasterOdin-patch-1 branch February 17, 2022 13:38
@navarroaxel navarroaxel removed the review needed Prioritized PRs marked for reviews from maintainers. label Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues/PRs modifying the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client spec: osx and macos
6 participants