-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLIENT-SPECIFICATION: add macos recommendation #7514
Conversation
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me! This will be a long process to rename osx
to macos
I'm sure, but it's great to take the first step towards that here.
Could we update the client specification changelog (at the bottom of the file) for this too please?
@sbrl I've updated the changelog at the bottom, but did you want me to set the version to 1.6 throughout, or will that happen in its own PR (like other version releases)? |
Regarding the version number bump, I can open a PR for that when we have #7561 merged, as that should make it into v1.6 I think. I'll also write a release when that's done. |
whoops, reviewed twice! |
This comment was marked as outdated.
This comment was marked as outdated.
Friendly bump @sbrl! |
Closes #7076. This adds to the specification that it's recommended to treat
macos
as an alias forosx
. At some point it might be good to migrate tomacos
for folder structure, this at least is a step in that direction.