Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-cognito-idp: add page #9032

Merged
merged 4 commits into from Oct 15, 2022
Merged

aws-cognito-idp: add page #9032

merged 4 commits into from Oct 15, 2022

Conversation

ShivamJoker
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 2.8.2

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 14, 2022
@ShivamJoker
Copy link
Contributor Author

From #5653
@navarroaxel can you please review?

@kbdharun kbdharun mentioned this pull request Oct 15, 2022
Open
navarroaxel
navarroaxel reviewed Oct 15, 2022
View reviewed changes
pages/common/aws-cognito-idp.md Outdated Show resolved Hide resolved
pages/common/aws-cognito-idp.md Outdated Show resolved Hide resolved
pages/common/aws-cognito-idp.md Outdated Show resolved Hide resolved
pages/common/aws-cognito-idp.md Outdated Show resolved Hide resolved
pages/common/aws-cognito-idp.md Outdated Show resolved Hide resolved
pages/common/aws-cognito-idp.md Outdated Show resolved Hide resolved
pages/common/aws-cognito-idp.md Outdated Show resolved Hide resolved
pages/common/aws-cognito-idp.md Outdated Show resolved Hide resolved
@ShivamJoker @navarroaxel
Aws-cognitive-dip: Apply suggestions from code review
1329dbc 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@ShivamJoker
Copy link
Contributor Author

All done

@ShivamJoker @kbdharun
aws-cognito-idp: make result a variable
a3c4bb6 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
kbdharun
kbdharun approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@navarroaxel navarroaxel merged commit 94cdc9b into tldr-pages:main Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShivamJoker @navarroaxel @kbdharun