Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-codecommit: add page #9202

Merged
merged 12 commits into from
Oct 25, 2022
Merged

aws-codecommit: add page #9202

merged 12 commits into from
Oct 25, 2022

Conversation

Abhay5855
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@CLAassistant

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 20, 2022
@tldr-bot

This comment was marked as outdated.

Sign in to view
@Abhay5855
Copy link
Contributor Author

I have added the aws codecommit configuration on cli following proper Guides and passing all the Tests please review this -
#9202

@kbdharun kbdharun mentioned this pull request Oct 20, 2022
Open
@kbdharun kbdharun changed the title add codecommit commands on cli aws-codecommit: add page Oct 20, 2022
@kbdharun
Copy link
Member

Thanks for your contribution, Welcome to tldr. I updated the name of the file. Now, I will review the contents.

kbdharun
kbdharun reviewed Oct 20, 2022
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have some suggestions for this page.

pages/common/aws-codecommit.md Outdated Show resolved Hide resolved
pages/common/aws-codecommit.md Show resolved Hide resolved
pages/common/aws-codecommit.md Outdated Show resolved Hide resolved
pages/common/aws-codecommit.md Outdated Show resolved Hide resolved
pages/common/aws-codecommit.md Outdated Show resolved Hide resolved
pages/common/aws-codecommit.md Outdated Show resolved Hide resolved
pages/common/aws-codecommit.md Outdated Show resolved Hide resolved
pages/common/aws-codecommit.md Outdated Show resolved Hide resolved
pages/common/aws-codecommit.md Outdated Show resolved Hide resolved
pages/common/aws-codecommit.md Outdated Show resolved Hide resolved
@Abhay5855
Copy link
Contributor Author

@kbdharun Thanks for letting me know the changes requested I have updated the PR with the requested changes as expected -
PR - #9202

@Abhay5855
Copy link
Contributor Author

@kbdharun Any updates on my PR?

@kbdharun
Copy link
Member

kbdharun commented Oct 23, 2022 •
edited

@kbdharun Any updates on my PR?

I looked into it @Abhay5855 Can you apply the suggestion I made above?

kbdharun
kbdharun reviewed Oct 23, 2022
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply the suggestion, I made above along with this too.

Tip: Batch all my suggestions in Files changed tab of this PR and make a single commit

pages/common/aws-codecommit.md Outdated Show resolved Hide resolved
pages/common/aws-codecommit.md Outdated Show resolved Hide resolved
@Abhay5855
Copy link
Contributor Author

@kbdharun any update on PR I have moved the command to last as expected.

@navarroaxel navarroaxel merged commit 61c26c3 into tldr-pages:main Oct 25, 2022
@Abhay5855
Copy link
Contributor Author

@kbdharun @navarroaxel Thanks for accepting my PR happy to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Abhay5855 @CLAassistant @tldr-bot @kbdharun @navarroaxel