Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "Loading assets" screen dark #1248

Closed
Fabian9799 opened this issue Mar 10, 2023 · 1 comment
Closed

Make "Loading assets" screen dark #1248

Fabian9799 opened this issue Mar 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Fabian9799
Copy link

When darkmode is enabled the "loading assets" screen displayed when the page is first beeing loaded is still shown in lightmode.
It would be nice to also have that in darkmode.

Actual footage of me using the tldraw website at 3am in the morning:
cat-blind-flashbang-light-mode
@TodePond
Copy link
Collaborator

Oh no! Great point - thanks for the report :)

@TodePond TodePond added the bug Something isn't working label Mar 10, 2023
@TodePond TodePond transferred this issue from tldraw/tldraw-beta May 5, 2023
@MitjaBezensek MitjaBezensek mentioned this issue Jun 8, 2023
Merged
1 task
steveruizok added a commit that referenced this issue Jun 15, 2023
@MitjaBezensek @steveruizok
Make sure loading screens use dark mode user preference. (#1552)
86e0010 
We load the user preferences a bit earlier, so that we can make sure
that the `LoadingScreen` and `ErrorScreen` also use the correct color
and background color based on the dark mode setting.

There's still a brief flash of white screen, but that's before any of
our components load, not sure if we can avoid that one.

Solves #1248

### Change Type

- [x] `patch` — Bug Fix

### Test Plan

1. Probably best if you throttle your network speed.
2. Reload the page.
3. The asset loading screen should use take your dark mode setting into
account.
4. Change the dark mode and try again.

### Release Notes

- Make sure our loading and error screens take dark mode setting into
account.

---------

Co-authored-by: Steve Ruiz <steveruizok@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TodePond @Fabian9799 @Taha-Hassan-Git