Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touch: Can resize image shapes by dragging edges #2349

Closed
MitjaBezensek opened this issue Dec 19, 2023 · 0 comments · Fixed by #2347
Closed

Touch: Can resize image shapes by dragging edges #2349

MitjaBezensek opened this issue Dec 19, 2023 · 0 comments · Fixed by #2347
Assignees
@MitjaBezensek

Comments

@MitjaBezensek
Copy link
Contributor

On touch, no edge resizing UNLESS a single text shape is selected
@MitjaBezensek MitjaBezensek self-assigned this Dec 19, 2023
@MitjaBezensek MitjaBezensek mentioned this issue Dec 19, 2023
Merged
8 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 19, 2023
@MitjaBezensek
Only allow side resizing when we have some shapes that are not aspect…
2a02650 
… ratio locked (#2347)

Only allow edges resizing on mobile when a single text shape is
selected. Disabled it for all other cases.

Fixes [#2349](#2349)

### Change Type

- [x] `patch` — Bug fix
- [ ] `minor` — New feature
- [ ] `major` — Breaking change
- [ ] `dependencies` — Changes to package dependencies[^1]
- [ ] `documentation` — Changes to the documentation only[^2]
- [ ] `tests` — Changes to any test code only[^2]
- [ ] `internal` — Any other changes that don't affect the published
package[^2]
- [ ] I don't know

[^1]: publishes a `patch` release, for devDependencies use `internal`
[^2]: will not publish a new version


### Release Notes

- Don't allow edges resizing on mobile. The only exception is a single
text shape.
@mimecuvalo mimecuvalo mentioned this issue Jan 11, 2024
Merged
10 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 12, 2024
@mimecuvalo
[fix] disable vertical edge resizing for text on mobile (#2456)
dca7883 
This is a followup to PR #2347 which was addressing #2349.
This makes sure that vertical resizing is disabled still for the text
shapes because they get in the way of rotation.

Fixes #2455 

### Change Type

- [x] `patch` — Bug fix
- [ ] `minor` — New feature
- [ ] `major` — Breaking change
- [ ] `dependencies` — Changes to package dependencies[^1]
- [ ] `documentation` — Changes to the documentation only[^2]
- [ ] `tests` — Changes to any test code only[^2]
- [ ] `internal` — Any other changes that don't affect the published
package[^2]
- [ ] I don't know

[^1]: publishes a `patch` release, for devDependencies use `internal`
[^2]: will not publish a new version

### Test Plan

1. Add a step-by-step description of how to test your PR here.
2.

- [ ] Unit Tests
- [ ] End to end tests

### Release Notes

- Add a brief release note for your PR here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MitjaBezensek MitjaBezensek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only allow side resizing when we have some shapes that are not aspect ratio locked tldraw/tldraw
1 participant
@MitjaBezensek