Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Bookmarks not showing image and description preview in VS Code extension #2363

Closed
1 task done
pranjaldugar opened this issue Dec 20, 2023 · 3 comments · Fixed by #2449
Closed
1 task done

[Bug]: Bookmarks not showing image and description preview in VS Code extension #2363

pranjaldugar opened this issue Dec 20, 2023 · 3 comments · Fixed by #2449
Labels
bug Something isn't working

Comments

@pranjaldugar
Copy link

What happened?

:) Thanks

How can we reproduce the bug?

No response

What browsers are you seeing the problem on?

No response

Contact Details

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@pranjaldugar pranjaldugar added the bug Something isn't working label Dec 20, 2023
@pranjaldugar
Copy link
Author

Adding to this it would also be great if we can use favicon when background image (social image) not found.

@steveruizok
Copy link
Collaborator

Hey @pranjaldugar, we did try that early on! But it looked pretty broken in most cases.

This does look like it could be a bug though, @MitjaBezensek can you take a look?

For additional context: on tldraw.com, we get social data from an endpoint that is designed to fetch it safely, and use a less reliable “backup” strategy when that fails. In the VS code extension, we have to rely only on this “backup” strategy because the VS code extension needs to work independently.

@MitjaBezensek MitjaBezensek mentioned this issue Jan 11, 2024
Merged
10 tasks
@MitjaBezensek
Copy link
Contributor

Nice catch! Just created a PR that should solve it. If all goes well this will be fixed next week when we do a new release of the extension.

github-merge-queue bot pushed a commit that referenced this issue Jan 12, 2024
@MitjaBezensek
Fix bookmark info for VS Code (#2449)
fa98765 
During the SPA spike we replaced our bookmark API endpoint with a
completely new service just for bookmarks, but we forgot to update the
URL in the vs code extension. This should now make the bookmark images
and descriptions work again in VS Code.

Fixes #2363

### Change Type

- [x] `patch` — Bug fix
- [ ] `minor` — New feature
- [ ] `major` — Breaking change
- [ ] `dependencies` — Changes to package dependencies[^1]
- [ ] `documentation` — Changes to the documentation only[^2]
- [ ] `tests` — Changes to any test code only[^2]
- [ ] `internal` — Any other changes that don't affect the published
package[^2]
- [ ] I don't know

[^1]: publishes a `patch` release, for devDependencies use `internal`
[^2]: will not publish a new version

### Test Plan

1. Run the VS Code extension.
2. Paste a link (like https://github.com/tldraw/tldraw)
3. The bookmark should have an image and description.

- [ ] Unit Tests
- [ ] End to end tests

### Release Notes

- Fix bookmark image and description for VS code extension.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bookmark info for VS Code tldraw/tldraw
3 participants
@MitjaBezensek @steveruizok @pranjaldugar