Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[windows] Pasting an image from tab↔tab (or browser chrome↔edge) causes a crash #2437

Closed
MitjaBezensek opened this issue Jan 10, 2024 · 0 comments · Fixed by #2436
Closed

[windows] Pasting an image from tab↔tab (or browser chrome↔edge) causes a crash #2437

MitjaBezensek opened this issue Jan 10, 2024 · 0 comments · Fixed by #2436
Assignees
@MitjaBezensek

Comments

@MitjaBezensek
Copy link
Contributor

image.props.src expected string, got null

Also happens on macos copying from chrome into firefox
@MitjaBezensek MitjaBezensek self-assigned this Jan 10, 2024
@MitjaBezensek MitjaBezensek mentioned this issue Jan 10, 2024
Merged
10 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 10, 2024
@MitjaBezensek @SomeHats
Fix validation when pasting images. (#2436)
ca9ae8e 
Before introducing url / src validation [we allowed
nulls](https://github.com/tldraw/tldraw/pull/2428/files#diff-28a9f0a3d4797d7addd1d61d336fc00acdec878273ac09f048e2e2dfaf77a037L30)
for src so I updated validations to reflect that.

Fixes [#2437](#2437)

### Change Type

- [x] `patch` — Bug fix
- [ ] `minor` — New feature
- [ ] `major` — Breaking change
- [ ] `dependencies` — Changes to package dependencies[^1]
- [ ] `documentation` — Changes to the documentation only[^2]
- [ ] `tests` — Changes to any test code only[^2]
- [ ] `internal` — Any other changes that don't affect the published
package[^2]
- [ ] I don't know

[^1]: publishes a `patch` release, for devDependencies use `internal`
[^2]: will not publish a new version

### Test Plan

1. Copy an image in tldraw in one browser (`cmd + c`)
2. Paste it to a different browser (or at least private mode of the same
browser)
3. Paste should work and you should not see any errors in the console.

- [ ] Unit Tests
- [ ] End to end tests

### Release Notes

- Fixes url validations.

---------

Co-authored-by: alex <alex@dytry.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MitjaBezensek MitjaBezensek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix validation when pasting images. tldraw/tldraw
1 participant
@MitjaBezensek