Need to do a hard reload to get the new styles #2486
Assignees
Comments
1 task
ds300
added a commit
that referenced
this issue
Jan 19, 2024
A few things happening here - Delete our service worker. Turns out that a couple of years back browsers decided that a service worker is no longer required for a PWA so you can just have the manifest and still install on the user's device. - Cache tldraw's assets as part of the dotcom vite asset pipeline. This allows them to participate in the asset coalescing (preserving old versions of asset files so old clients don't stop working when you deploy new versions of things, see tldraw/brivate#3132 for more context). - Add a new 'imports.vite.js' file to the assets package, because we import a bunch of json translation files, and vite imports .json files as parsed json objects instead of string urls, and there's no good way to tell it not to. Even if there was we wouldn't want to impose that config on our users. So another way to tell vite to load any asset as a url string is to append `?url` to the end of the import path. That's what this file does. closes [#2486](#2486) ### Change Type - [x] `minor` — New feature [^1]: publishes a `patch` release, for devDependencies use `internal` [^2]: will not publish a new version ### Release Notes - Fix 'could not load assets' error that we often see on tldraw.com after a deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When opening staging I didn't not see the new dark mode colors. I had to refresh the page to get them. Happened in different browsers and also on two different devices.
Probably a service worker caching issue.
The text was updated successfully, but these errors were encountered: