Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow label can overlap its bound shape when it has no arrow head #3433

Closed
SomeHats opened this issue Apr 10, 2024 · 1 comment · Fixed by #3512
Closed

Arrow label can overlap its bound shape when it has no arrow head #3433

SomeHats opened this issue Apr 10, 2024 · 1 comment · Fixed by #3512
Assignees
@mimecuvalo
Labels
bug Something isn't working

Comments

@SomeHats
Copy link
Contributor

We do this to allow dragging all the way to arrow-start on unbound arrows, but for bound ones we should prevent the label from going all the way to the start.

Image
@linear Linear
Copy link

linear bot commented Apr 10, 2024

TLD-2386 Arrow label can overlap its bound shape when it has no arrow head

@SomeHats SomeHats added the bug Something isn't working label Apr 10, 2024
@mimecuvalo mimecuvalo mentioned this issue Apr 17, 2024
Merged
13 tasks
@mimecuvalo mimecuvalo self-assigned this Apr 17, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 17, 2024
@mimecuvalo
arrows: fix bound arrow labels going over text shape (#3512)
d247b5d 
Fixes #3433

### Change Type

<!-- ❗ Please select a 'Scope' label ❗️ -->

- [x] `sdk` — Changes the tldraw SDK
- [ ] `dotcom` — Changes the tldraw.com web app
- [ ] `docs` — Changes to the documentation, examples, or templates.
- [ ] `vs code` — Changes to the vscode plugin
- [ ] `internal` — Does not affect user-facing stuff

<!-- ❗ Please select a 'Type' label ❗️ -->

- [x] `bugfix` — Bug fix
- [ ] `feature` — New feature
- [ ] `improvement` — Improving existing features
- [ ] `chore` — Updating dependencies, other boring stuff
- [ ] `galaxy brain` — Architectural changes
- [ ] `tests` — Changes to any test code
- [ ] `tools` — Changes to infrastructure, CI, internal scripts,
debugging tools, etc.
- [ ] `dunno` — I don't know


### Release Notes

- Arrows: fix label positioning when bound.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mimecuvalo mimecuvalo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

arrows: fix bound arrow labels going over text shape tldraw/tldraw
2 participants
@mimecuvalo @SomeHats