Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't edit document title when editing text #3437

Closed
TodePond opened this issue Apr 10, 2024 · 1 comment · Fixed by #3459
Closed

Can't edit document title when editing text #3437

TodePond opened this issue Apr 10, 2024 · 1 comment · Fixed by #3459

Comments

@TodePond
Copy link
Collaborator

  1. In a shared board...
  2. Make a text shape...
  3. Start editing the text shape...
  4. Double click the document title...

Expected: Edit the document title.
Actual: Stay editing the text shape

Copy link

linear bot commented Apr 10, 2024

github-merge-queue bot pushed a commit that referenced this issue Apr 13, 2024
…n editing a shape. (#3459)

Fixes [#3437](#3437)

### Change Type

<!-- ❗ Please select a 'Scope' label ❗️ -->

- [ ] `sdk` — Changes the tldraw SDK
- [x] `dotcom` — Changes the tldraw.com web app
- [ ] `docs` — Changes to the documentation, examples, or templates.
- [ ] `vs code` — Changes to the vscode plugin
- [ ] `internal` — Does not affect user-facing stuff

<!-- ❗ Please select a 'Type' label ❗️ -->

- [x] `bugfix` — Bug fix
- [ ] `feature` — New feature
- [ ] `improvement` — Improving existing features
- [ ] `chore` — Updating dependencies, other boring stuff
- [ ] `galaxy brain` — Architectural changes
- [ ] `tests` — Changes to any test code
- [ ] `tools` — Changes to infrastructure, CI, internal scripts,
debugging tools, etc.
- [ ] `dunno` — I don't know


### Test Plan

1. Create a shared document
2. Add a text note and start editing it
3. Double click document name. You should be now editing the document
name.

- [ ] Unit Tests
- [ ] End to end tests

### Release Notes

- Allow users to editing document name by double clicking even when
previously editing text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant