Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Youtube links get blocked when going from embed→main site #3593

Closed
mimecuvalo opened this issue Apr 24, 2024 — with Linear · 1 comment · Fixed by #3609
Closed

Youtube links get blocked when going from embed→main site #3593

mimecuvalo opened this issue Apr 24, 2024 — with Linear · 1 comment · Fixed by #3609
Assignees
@mimecuvalo

Comments

@mimecuvalo Linear
Copy link
Contributor

mimecuvalo commented Apr 24, 2024 •
edited

When clicking on a YouTube embed and clicking on the YT logo to go to the main YT site, it gets blocked.

Kapture 2024-04-24 at 15.48.06.mp4
@linear Linear
Copy link

linear bot commented Apr 24, 2024

TLD-2453 Youtube links get blocked when going from embed→main site

@mimecuvalo mimecuvalo mentioned this issue Apr 25, 2024
Merged
13 tasks
@mimecuvalo mimecuvalo self-assigned this Apr 25, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 29, 2024
@mimecuvalo @steveruizok
embed: allow embeds like YouTube to link back to its site (#3609)
487addd 
Fixes #3593

(some drive-by spelling/grammar cleanup)

### Change Type

<!-- ❗ Please select a 'Scope' label ❗️ -->

- [x] `sdk` — Changes the tldraw SDK
- [ ] `dotcom` — Changes the tldraw.com web app
- [ ] `docs` — Changes to the documentation, examples, or templates.
- [ ] `vs code` — Changes to the vscode plugin
- [ ] `internal` — Does not affect user-facing stuff

<!-- ❗ Please select a 'Type' label ❗️ -->

- [x] `bugfix` — Bug fix
- [ ] `feature` — New feature
- [ ] `improvement` — Improving existing features
- [ ] `chore` — Updating dependencies, other boring stuff
- [ ] `galaxy brain` — Architectural changes
- [ ] `tests` — Changes to any test code
- [ ] `tools` — Changes to infrastructure, CI, internal scripts,
debugging tools, etc.
- [ ] `dunno` — I don't know


### Release Notes

- Embeds: fix being able to click on links that go back to the embed's
site (e.g. YouTube)

---------

Co-authored-by: Steve Ruiz <steveruizok@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mimecuvalo mimecuvalo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

embed: allow embeds like YouTube to link back to its site tldraw/tldraw
1 participant
@mimecuvalo