fix pointer location not updated in edit mode

[tomi-bigpi]

Currently useShapeEvents.pointerEventHandler sets killed = true when pointer events are received over a shape that's in edit mode. However, this also stops pointer_move events, and that means that inputs.currentPagePoint will be wrong while you move into or in a shape. The fallout, and the main issue for us, is that this breaks the checks for canScroll / bounds?.containsPoint(app.inputs.currentPagePoint) and canScroll isn't honored and we can't scroll content in certain situations.

Change Type

• patch — Bug Fix

• minor — New Feature

• major — Breaking Change

• dependencies — Dependency Update (publishes a patch release, for devDependencies use internal)

• documentation — Changes to the documentation only (will not publish a new version)

• tests — Changes to any testing-related code only (will not publish a new version)

• internal — Any other changes that don't affect the published package (will not publish a new version)

Test Plan

1. Put shape that has scrollable content into edit mode
2. Use scrollwheel = content scrolls as it should
3. Move the mouse outside the shape and use the scrollwheel (to move the canvas and get a desired bit of the shape into view better, for example)
4. Move the pointer back inside the shape
5. Use scrollwheel - canvas scrolls since the app thinks the current position is outside (right on the border) of the shape where it last updated it

Release Notes

• Fix pointer location not updated in edit mode after moving cursor out of shape and back into shape area

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
examples	✅ Ready (Inspect)	Visit Preview	May 11, 2023 7:15pm
tldraw-docs-staging	✅ Ready (Inspect)	Visit Preview	May 11, 2023 7:15pm

[steveruizok]

This is a good one Tomi! We're currently waiting on getting a CLA so that we can take contributions from the community, so I can't merge this one. However that may take a few more days, and this seems like an impactful change for you, I will gladly do the little legal dance and make a separate PR that implements the same thing. 🙃

[steveruizok]

Closing but only for the above reason. Thank you @tomi-bigpi !

[tomi-bigpi]

@steveruizok No worries, I've got a custom patch on that via pnpm patch, so no rush.