fix pointer location not updated in edit mode #1352
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
useShapeEvents.pointerEventHandler
setskilled = true
when pointer events are received over a shape that's in edit mode. However, this also stopspointer_move events
, and that means thatinputs.currentPagePoint
will be wrong while you move into or in a shape. The fallout, and the main issue for us, is that this breaks the checks forcanScroll
/bounds?.containsPoint(app.inputs.currentPagePoint)
andcanScroll
isn't honored and we can't scroll content in certain situations.Change Type
patch
— Bug Fixminor
— New Featuremajor
— Breaking Changedependencies
— Dependency Update (publishes apatch
release, for devDependencies useinternal
)documentation
— Changes to the documentation only (will not publish a new version)tests
— Changes to any testing-related code only (will not publish a new version)internal
— Any other changes that don't affect the published package (will not publish a new version)Test Plan
Release Notes