Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache playwright browsers. #2067

Merged
merged 3 commits into from Oct 12, 2023
Merged

Cache playwright browsers. #2067

merged 3 commits into from Oct 12, 2023

Conversation

MitjaBezensek
Copy link
Contributor

@MitjaBezensek MitjaBezensek commented Oct 11, 2023 •
edited

Adds caching for playwright browsers, should make the e2e tests run much faster.

CleanShot 2023-10-11 at 13 06 48

Here's how it looks like when there's a cache hit (added an empty commit to this PR to test it out)
CleanShot 2023-10-11 at 13 19 30

Change Type

  • patch — Bug fix
  • minor — New feature
  • major — Breaking change
  • dependencies — Changes to package dependencies1
  • documentation — Changes to the documentation only2
  • tests — Changes to any test code only2
  • internal — Any other changes that don't affect the published package2
  • I don't know

Footnotes

  1. publishes a patch release, for devDependencies use internal ↩

  2. will not publish a new version ↩ ↩2 ↩3

@huppy-bot huppy-bot bot added the tests Add or improve existing tests label Oct 11, 2023
@vercel
Copy link

vercel bot commented Oct 11, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview Oct 11, 2023 11:20am

ds300
ds300 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@ds300 ds300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heck yeah! 📉

@MitjaBezensek MitjaBezensek added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 8f18507 Oct 12, 2023
5 checks passed
@MitjaBezensek MitjaBezensek deleted the mitja/cache-playwright-browsers branch October 12, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds300 ds300 ds300 approved these changes

@steveruizok steveruizok Awaiting requested review from steveruizok

Assignees
No one assigned
Labels
tests Add or improve existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MitjaBezensek @ds300