Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR does a couple of things when creating bookmarks
fetch
on the url to check whether the url is an image that we have cors access to. In that case we can paste the image itself rather than a bookmark. But that's gonna be a relatively rare use case, and the check itself seemed to cost anywhere from 200ms to +1s which is certainly not worth it when the fallback behaviour (create a regular bookmark) is fine. So i moved that check behind a url pathname extension check. i.e. if the url pathname ends with .gif, .jpg, .jpeg, .svg, or .png, then it will check whether we can paste the image directly, otherwise it will always do a regular bookmark.It looks like this
Change Type
minor
— New featureRelease Notes