Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate/refactor store events example #2400

Merged
merged 3 commits into from Jan 3, 2024
Merged

Annotate/refactor store events example #2400

merged 3 commits into from Jan 3, 2024

Conversation

Taha-Hassan-Git
Copy link
Contributor

@Taha-Hassan-Git Taha-Hassan-Git commented Jan 3, 2024 •
edited

This example refactors the store events example to use the store.listen method and adds annotations to explain the code.

Change Type

  • patch — Bug fix
  • minor — New feature
  • major — Breaking change
  • dependencies — Changes to package dependencies1
  • documentation — Changes to the documentation only2
  • tests — Changes to any test code only2
  • internal — Any other changes that don't affect the published package2
  • I don't know

Test Plan

  1. Add a step-by-step description of how to test your PR here.
  • Unit Tests
  • End to end tests

Release Notes

  • Update store events example to use store.listen method
  • Annotate with explanations of the code

Footnotes

  1. publishes a patch release, for devDependencies use internal ↩

  2. will not publish a new version ↩ ↩2 ↩3

@vercel Vercel
Copy link

vercel bot commented Jan 3, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview Jan 3, 2024 0:41am

@huppy-bot huppy-bot bot added the docs Changes only affect the documentation label Jan 3, 2024
@Taha-Hassan-Git Taha-Hassan-Git added this pull request to the merge queue Jan 3, 2024
Merged via the queue into main with commit 918e735 Jan 3, 2024
6 checks passed
@Taha-Hassan-Git Taha-Hassan-Git deleted the taha/annotate-store-events branch January 3, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveruizok steveruizok steveruizok approved these changes

Assignees
No one assigned
Labels
docs Changes only affect the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Taha-Hassan-Git @steveruizok