Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where the video size was not drawn correctly #3047

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

bubweiser
Copy link
Contributor

Fixed an issue where the video size was drawing larger than the shape size.

After:
スクリーンショット 2024-03-04 15 38 10

Before:
スクリーンショット 2024-03-04 15 37 32

Change Type

  • patch — Bug fix
  • minor — New feature
  • major — Breaking change
  • dependencies — Changes to package dependencies1
  • documentation — Changes to the documentation only2
  • tests — Changes to any test code only2
  • internal — Any other changes that don't affect the published package2
  • I don't know

Test Plan

no tests

Release Notes

  • Fix an issue where the video size was not drawn correctly.

Footnotes

  1. publishes a patch release, for devDependencies use internal

  2. will not publish a new version 2 3

Copy link

vercel bot commented Mar 4, 2024

@bubweiser is attempting to deploy a commit to the tldraw Team on Vercel.

A member of the Team first needs to authorize it.

@huppy-bot huppy-bot bot added the bugfix Bug fix label Mar 4, 2024
@huppy-bot
Copy link
Contributor

huppy-bot bot commented Mar 4, 2024

2 out of 2 authors have signed the CLA.

Thanks!

@bubweiser
Copy link
Contributor Author

I have read and agree to the Contributor License Agreement.

@steveruizok
Copy link
Collaborator

Eek, good catch @bubweiser !

@steveruizok
Copy link
Collaborator

Note to self: always test at not 100% zoom

Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview Mar 4, 2024 1:45pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
tldraw-docs ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2024 1:45pm

@steveruizok steveruizok added this pull request to the merge queue Mar 4, 2024
Merged via the queue into tldraw:main with commit 5e4bca9 Mar 4, 2024
7 of 8 checks passed
@bubweiser bubweiser deleted the fix_video_shape_util branch March 5, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants