Faster selection / erasing #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
huppy-bot
bot
added
improvement
steveruizok
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
steveruizok
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
steveruizok
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
|
I've also made some improvements to the speed of erasing and made margins work for hit segment hit testing, which were previously not working. This makes erasing perform as intended (with a "margin" around the eraser) rather than requiring the eraser to intersect a shape's geometry. |
steveruizok
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
steveruizok
changed the title
|
Turns out with lots of shapes on the screen, showing and hiding indicators becomes slow; we can speed things up by leaving the indicators in the DOM and switching their display properties instead. |
steveruizok
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
steveruizok
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
13 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
A little regression from #3454. We still need the exact distance here. ### Change Type <!-- ❗ Please select a 'Scope' label ❗️ --> - [x] `sdk` — Changes the tldraw SDK - [ ] `dotcom` — Changes the tldraw.com web app - [ ] `docs` — Changes to the documentation, examples, or templates. - [ ] `vs code` — Changes to the vscode plugin - [ ] `internal` — Does not affect user-facing stuff <!-- ❗ Please select a 'Type' label ❗️ --> - [x] `bugfix` — Bug fix - [ ] `feature` — New feature - [ ] `improvement` — Improving existing features - [ ] `chore` — Updating dependencies, other boring stuff - [ ] `galaxy brain` — Architectural changes - [ ] `tests` — Changes to any test code - [ ] `tools` — Changes to infrastructure, CI, internal scripts, debugging tools, etc. - [ ] `dunno` — I don't know ### Release Notes - Fix arrow label positioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small improvement to the way we measure distances. (Often we measure distances multiple times per frame per shape on the screen). In many cases, we compare a minimum distance. This makes those checks faster by avoiding a square root.
Change Type
sdk— Changes the tldraw SDKimprovement— Improving existing featuresRelease Notes