Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textfields: fix up flakiness in text selection #3578

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

mimecuvalo
Copy link
Member

This PR #3498 which tried to fix accidentally dragging shapes behind other shapes made clicking into textfields worse unfortunately. (as seen below in the Before video).

This PR takes a different tact by introducing not just data-iseditinganything but now also data-isselectinganything which makes Shapes z-indices actually be relevant vs. the canvas being the top z-index layer, when something is selected or being editing. It's worth a good think over this and any downstream consequences this might introduce. I think this change will actually be ok for when we're in select state but I wouldn't be surprised if I'm missing some nuance.

Before:

Kapture.2024-04-23.at.16.19.04.mp4

After:

Kapture.2024-04-23.at.16.18.32.mp4

Change Type

  • sdk — Changes the tldraw SDK
  • dotcom — Changes the tldraw.com web app
  • docs — Changes to the documentation, examples, or templates.
  • vs code — Changes to the vscode plugin
  • internal — Does not affect user-facing stuff
  • bugfix — Bug fix
  • feature — New feature
  • improvement — Improving existing features
  • chore — Updating dependencies, other boring stuff
  • galaxy brain — Architectural changes
  • tests — Changes to any test code
  • tools — Changes to infrastructure, CI, internal scripts, debugging tools, etc.
  • dunno — I don't know

Release Notes

  • Textfields: fix up regression to selection when clicking into a text shape.

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview Apr 23, 2024 3:27pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
tldraw-docs ⬜️ Ignored (Inspect) Apr 23, 2024 3:27pm

@steveruizok steveruizok merged commit cc12b7b into mime/textfields-geo-fill Apr 27, 2024
7 checks passed
@steveruizok steveruizok deleted the mime/textfields-selection branch April 27, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants