Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pressure-detection logic in drawing #3639

Merged
merged 9 commits into from Apr 29, 2024
Merged

Conversation

steveruizok
Copy link
Collaborator

This PR improves handling of pressure in the draw tool. While we differentiate between pen and not-pen in the pointer type, there are not-pen type inputs like styluses that present as "mouse" inputs. This PR makes the freehand options for these inputs more pen-like so that they benefit from the dialing-in of options for pressure-using devices.

Change Type

  • sdk — Changes the tldraw SDK
  • improvement — Improving existing features

Test Plan

  1. Use pen inputs
  2. Use mouse inputs
  3. Use stylus inputs
  • Unit Tests

Release Notes

  • Improves handling of mouse-type devices that support pressure, e.g. wacom tablets. They now use the same freehand options as true pen-type inputs.

@huppy-bot huppy-bot bot added improvement Improves existing features sdk Affects the tldraw sdk labels Apr 29, 2024
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview Apr 29, 2024 8:42pm
tldraw-docs ✅ Ready (Inspect) Visit Preview Apr 29, 2024 8:42pm

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by, remove duplicated code

@steveruizok steveruizok added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit b8afbb4 Apr 29, 2024
10 checks passed
@steveruizok steveruizok deleted the improve-pen-logic branch April 29, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves existing features sdk Affects the tldraw sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant